fnordig/blog
1
Fork 0
Code Activity

Apply suggestions from code review

Browse source 
Co-Authored-By: Chris H-C <chutten@users.noreply.github.com>
This commit is contained in:
Jan-Erik Rediger 2019-11-29 18:20:21 +01:00 committed by GitHub
parent f4bb8a5075
commit 029b7b4b8f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
_posts/2019-11-29-this-week-in-glean.md
View file

@ -7,21 +7,21 @@ data:
route: blog route: blog
--- ---
(“This Week in Glean” is a series of blog posts that the Glean Team at Mozilla is using to try to communicate better about our work. They could be release notes, documentation, hopes, dreams, or whatever: so long as it is inspired by Glean. You can find an [index of all TWiG posts online](https://mozilla.github.io/glean/book/appendix/twig.html)) (“This Week in Glean” is a series of blog posts that the Glean Team at Mozilla is using to try to communicate better about our work. They could be release notes, documentation, hopes, dreams, or whatever: so long as it is inspired by Glean. You can find an [index of all TWiG posts online](https://mozilla.github.io/glean/book/appendix/twig.html).)
Last week's blog post: [This Week in Glean: Glean in Private](https://chuttenblog.wordpress.com/2019/11/22/this-week-in-glean-glean-in-private/) by chutten. Last week's blog post: [This Week in Glean: Glean in Private](https://chuttenblog.wordpress.com/2019/11/22/this-week-in-glean-glean-in-private/) by chutten.
--- ---
Currently my team is responsible for the Telemetry framework inside Firefox on Desktop and also [Glean](https://github.com/mozilla/glean), targeting our mobile products. Currently my team is responsible for the Telemetry framework inside Firefox on Desktop and also [the Glean SDK](https://github.com/mozilla/glean), targeting our mobile products.
We're working on bringing the Glean experience to Firefox on Desktop, but in the meantime [Telemetry](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/index.html) is what we have, We're working on bringing the Glean experience to Firefox on Desktop, but in the meantime [Telemetry](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/index.html) is what we have,
need to support and sometimes implement new features on. need to support and sometimes implement new features on.
One of these features is a new ping (or better a change in a ping), that we now want to support across all our products. One of these features is a new ping (or, better, a change in a ping), that we now want to support across all our products.
I'm speaking of the [`deletion-request` ping](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/deletion-request-ping.html) here. I'm speaking of the [`deletion-request` ping](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/deletion-request-ping.html) here.
When a user opts out of Telemetry we take this as a signal to also delete associated data from our pipeline. When a user opts out of Telemetry we take this as a signal to also delete associated data from our pipeline.
Implementation in Firefox Desktop was merely renaming an existing ping that is triggered when the user disables "Data Collection and Use" (`about:preferences` -> Privacy & Security). It contains no additional data. Implementation in Firefox Desktop was merely renaming [an existing ping](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/obsolete/optout-ping.html) that is triggered when the user disables "Data Collection and Use" (`about:preferences` -> Privacy & Security). It contains no additional data.
Implementation in Glean was not much harder either. Glean already supports [custom pings](https://mozilla.github.io/glean/book/user/pings/custom.html): Pings that can be defined and send by the application using Glean. Implementation in Glean was not much harder either. Glean already supports [custom pings](https://mozilla.github.io/glean/book/user/pings/custom.html): Pings that can be defined and send by the application using Glean.
Glean's internal pings follow the same pattern, they are just pre-defined. Glean's internal pings follow the same pattern, they are just pre-defined.
The biggest difference? The biggest difference?
@ -33,7 +33,7 @@ Glean itself controls portion of the data, including a sequence number, date fie
and a bit of metadata about the application its running in (see [the ping sections](https://mozilla.github.io/glean/book/user/pings/index.html#ping-sections)). and a bit of metadata about the application its running in (see [the ping sections](https://mozilla.github.io/glean/book/user/pings/index.html#ping-sections)).
The rest of the payload consists of [metrics](https://mozilla.github.io/glean/book/user/metrics/index.html) as defined by users of Glean. The rest of the payload consists of [metrics](https://mozilla.github.io/glean/book/user/metrics/index.html) as defined by users of Glean.
While implementing the new ping I stumbled upon another small detail of Glean: Pings won't be sent out if they would not contain any metrics. While implementing the new ping I stumbled upon another small detail of Glean: Pings won't be sent out if they would not contain any metrics.
And our new ping by choice should not contain any metric! And our new ping, by design, should not contain any metrics!
We don't want to change this for other pings, so I had to introduce a new flag now: We don't want to change this for other pings, so I had to introduce a new flag now:
`sendIfEmpty` ([PR #139](https://github.com/mozilla/glean_parser/pull/139)). `sendIfEmpty` ([PR #139](https://github.com/mozilla/glean_parser/pull/139)).