Optional git-repository-url #6

2023-07-10T22:19:06Z

Wynd commented

2023-07-10 22:19:06 +00:00

(Migrated from github.com)

Made the git-repository-url config optional, when its not present in the config file it'll ignore the commit part of the footer message, leaving only the last changed date visible.
Updated the README.md file to take these changes into account.

The reasoning behind this change is simple, there are various circumstances such as private repos, non-github repos or simply wanting a design without the commit & its link in the footer that result in the preprocessor to become unusable due to the required git-repository-url. By making it optional a larger set of people are able to use it without restraints.

- Made the `git-repository-url` config optional, when its not present in the config file it'll ignore the commit part of the footer message, leaving only the last changed date visible. - Updated the `README.md` file to take these changes into account. The reasoning behind this change is simple, there are various circumstances such as private repos, non-github repos or simply wanting a design without the commit & its link in the footer that result in the preprocessor to become unusable due to the required `git-repository-url`. By making it optional a larger set of people are able to use it without restraints.

badboy (Migrated from github.com) approved these changes

2023-07-11 09:40:44 +00:00

badboy (Migrated from github.com) reviewed

2023-07-11 09:47:18 +00:00

src/lib.rs

					
				@ -21,26 +21,27 @@ impl Preprocessor for LastChanged {

				        log::debug!("Src root: {}", src_root.display());

        let repository_string: Option<&str> = match ctx.config.get("output.html.git-repository-url")
        {

```suggestion let repository_string: Option<&str> = match ctx.config.get("output.html.git-repository-url") { ```

Sign in to join this conversation.

No reviewers

badboy

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

jer/mdbook-last-changed!6

				`@ -21,26 +21,27 @@ impl Preprocessor for LastChanged {`
				`log::debug!("Src root: {}", src_root.display());`

Rows
Columns