jer/mdbook-mermaid
1
Fork 0
Code Issues 1 Pull requests Releases 26 Activity

Suggest a quicker and easier installation method #33

Closed
sanmai-NL wants to merge 2 commits from patch-1 into main
pull from: patch-1
merge into: jer:main
Conversation 2 Commits 2 Files changed 1 +22 -2
sanmai-NL commented 2023-05-13 18:28:29 +00:00 (Migrated from github.com)
Copy link

This is particularly useful to keep CI pipelines fast and concise.

This is particularly useful to keep CI pipelines fast and concise.
sanmai-NL commented 2023-12-22 14:54:59 +00:00 (Migrated from github.com)
Copy link

@badboy This seems like an easy to review PR after your holidays.

@badboy This seems like an easy to review PR after your holidays.
badboy (Migrated from github.com) requested changes 2024-01-05 12:00:45 +00:00
badboy (Migrated from github.com) left a comment
Copy link

Appreciate the work and I will add that install method, but I'm quickly wipping up the commit myself now.

Appreciate the work and I will add that install method, but I'm quickly wipping up the commit myself now.
README.md
@ -30,0 +32,4 @@
The simplest and quickest way to install is by [Cargo `binstall`](https://github.com/cargo-bins/cargo-binstall).
This installs the right binaries released here on GitHub (which you could also download manually).
badboy (Migrated from github.com) commented 2024-01-05 12:00:19 +00:00
Copy link

Indeed they are and we should call that out!

Indeed they are and we should call that out!
README.md
@ -30,0 +35,4 @@
```
yes | cargo binstall mdbook-mermaid
INFO resolve: Resolving package: 'mdbook-mermaid'
badboy (Migrated from github.com) commented 2024-01-05 11:59:30 +00:00
Copy link

We shouldn't encourage just accepting this as is (plus, IMO it would be better to pass --no-confirm in this case to better express intent).

We shouldn't encourage just accepting this as is (plus, IMO it would be better to pass `--no-confirm` in this case to better express intent).
README.md
@ -30,0 +43,4 @@
? INFO Installing binaries...
INFO Done in 1.248059328s
```
badboy (Migrated from github.com) commented 2024-01-05 12:00:07 +00:00
Copy link

No need for the full output, the command is enough.

No need for the full output, the command is enough.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
badboy
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jer/mdbook-mermaid!33
No description provided.