Add support for non-github.com URLs #1

Closed
opened 2020-09-29 11:42:49 +00:00 by wonderfulspam · 1 comment
wonderfulspam commented 2020-09-29 11:42:49 +00:00 (Migrated from github.com)

I'm using mdbook for a project located on a self-hosted GitLab instance. I see no reason why github.com is a mandatory part of the link; perhaps a debug warning could be printed instead of returning early?

Adding support for other Git hosts also means that the link text should be configurable. Happy to contribute a PR if you consider these changes to be within scope for this project!

I'm using mdbook for a project located on a self-hosted GitLab instance. I see no reason why `github.com` is a mandatory part of the link; perhaps a debug warning could be printed instead of returning early? Adding support for other Git hosts also means that the link text should be configurable. Happy to contribute a PR if you consider these changes to be within scope for this project!
wonderfulspam commented 2020-11-11 13:58:01 +00:00 (Migrated from github.com)

Closing this as I solved it in my fork. My solution isn't particularly clean but you're welcome to incorporate the changes here. Have tried to credit you incl. the copyright notice, let me know if there's any issues!

Closing this as I solved it in my [fork](https://github.com/wonderfulspam/mdbook-open-git-repo). My solution isn't particularly clean but you're welcome to incorporate the changes here. Have tried to credit you incl. the copyright notice, let me know if there's any issues!
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jer/mdbook-open-on-gh#1
No description provided.